Skip to content

Remove unsafe assertion from dynamic route screen detection - #100677

Merged
blimpich merged 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/s08-dynamic-route-screen-159f3a24
Sep 17, 2026
Merged

blimpich merged 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/s08-dynamic-route-screen-159f3a24

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This removes an unnecessary type assertion from dynamic-route screen detection. The configured path is already a string, and the existing Set<string> accepts it directly, so the optional lookup, empty-path guard, exact membership test, and navigation behavior stay unchanged.

The only changed file is src/libs/Navigation/helpers/dynamicRoutesUtils/isDynamicRouteScreen.ts.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

  • On macOS, open Chrome.

  • Sign in.

  • Go to Settings > Profile > Personal details > Home address > Country.

  • Verify the Country screen opens.

  • Verify the URL ends in /country.

  • Refresh the page.

  • Use Back.

  • Verify navigation returns to Home address.

  • Verify there is no unexpected fullscreen or routing state.

  • Open a regular Settings screen.

  • Refresh the page.

  • Use Back.

  • Verify refresh and Back behavior remain normal.

  • Check the JavaScript console for errors.

  • Note: These steps are recommended and have not been performed.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This cleanup changes no requests or offline handling; offline testing was not performed.

QA Steps

Same as test steps.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

26.Home_2026-09-13_05-11-07.mp4

Seatbelt-Operation: s08-159f3a24-00c6c5f-sign-1
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review September 16, 2026 09:36
@KJ21-ENG
KJ21-ENG requested review from a team as code owners September 16, 2026 09:36
@melvin-bot
melvin-bot Bot requested review from garrettmknight and ikevin127 and removed request for a team September 16, 2026 09:36
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 16, 2026 09:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-16T10:07:29.916948Z bff6c6b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ikevin127

ikevin127 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - No blocking findings during review. The change is correct, minimal, and behavior neutral.

@melvin-bot
melvin-bot Bot requested a review from blimpich September 16, 2026 23:12
@blimpich
blimpich merged commit 0e38568 into Expensify:main Sep 17, 2026
40 of 45 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.82-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR. I did not create a docs PR.

This change removes a TypeScript type assertion and its now-unused DynamicRouteSuffix import from src/libs/Navigation/helpers/dynamicRoutesUtils/isDynamicRouteScreen.ts. screenPath is already a string and dynamicRoutePaths is a Set<string>, so the membership test and every navigation outcome are byte-for-byte identical at runtime.

Why nothing in docs/articles is affected

Help site articles document what users see and do — feature names, tabs, settings, buttons, and step-by-step flows. This PR touches none of those:

  • No behavior change. Compile-time typing only. The PR's own test steps (Country screen opens, URL ends in /country, refresh and Back work) describe existing behavior being confirmed as unchanged, not new behavior.
  • No user-facing surface. No copy, labels, settings, permissions, or flows changed.
  • No matching articles. I searched docs/articles for dynamic-route and deep-link coverage. The only hit is Connect-Cursor-to-Expensify-Using-MCP.md, which is unrelated. Internal route resolution isn't documented on the help site at all.

Per HELP_AUTHORING_GUIDELINES.md, articles are written for the person using Expensify. There is no user-observable difference here to write about.

@KJ21-ENG, since there is no help site PR to review, please confirm this assessment instead. If you believe a user-facing behavior did change and should be documented, reply with @MelvinBot and the specific behavior, and I'll create the draft docs PR with the HelpDot label and assign it to you.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR, so I did not create a docs PR.

Why: the whole diff is a TypeScript type cleanup with no runtime or user-facing change. It drops the DynamicRouteSuffix import and the as DynamicRouteSuffix assertion in src/libs/Navigation/helpers/dynamicRoutesUtils/isDynamicRouteScreen.ts:19. The lookup target is already declared as Set<string> in isDynamicRouteSuffix.ts:9, so the assertion was a no-op. The compiled JavaScript is identical.

Nothing under docs/articles documents this code path. There is no new or renamed feature, no changed setting, no changed button or tab label, and no changed user flow — refresh and Back behavior on dynamic routes such as Country works exactly as before. Help site articles describe product behavior, not internal navigation typing, so there is nothing to add or correct.

If you expected a user-visible change here (for example, a routing fix a member would notice), tell me what it is and I'll scope the docs update.

@KJ21-ENG, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review — note there is no linked help site PR to review, since no docs change was needed.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants